Add test assertion for install_extension_in_lib default value #9241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…ialize Co-authored-by: hsbt <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback on DEFAULT_INSTALL_EXTENSION_IN_LIB change
Add test assertion for install_extension_in_lib default value
Jan 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a test assertion to verify that the install_extension_in_lib configuration property defaults to false when no configuration file specifies a value. This improves test coverage for the DEFAULT_INSTALL_EXTENSION_IN_LIB constant that was introduced in PR #9240.
- Added assertion to verify default value of
install_extension_in_libisfalse
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The
test_initializemethod intest_gem_config_file.rbdid not explicitly verify the default value ofinstall_extension_in_libwhen no configuration is provided. This left a gap in test coverage for the newDEFAULT_INSTALL_EXTENSION_IN_LIB = falseconstant introduced in PR #9240.What is your fix for the problem, implemented in this PR?
Added
assert_equal false, @cfg.install_extension_in_libin the first section oftest_initialize(line 46), which tests default values before any config file overrides are applied. This mirrors the existing assertions for other default config values likeipv4_fallback_enabled.The assertion validates that the config object correctly initializes with
install_extension_in_libset tofalsewhen no.gemrcconfiguration specifies otherwise.Make sure the following tasks are checked
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.